From: Derick Alangi <alangiderick@gmail.com>
Date: Thu, 18 Jul 2019 10:51:08 +0000 (+0100)
Subject: changes: Usage of 'noudp' & 'pleasedontudp' no longer exist
X-Git-Tag: 1.34.0-rc.0~921^2
X-Git-Url: http://git.cyclocoop.org/%22.%24match%5B1%5D.%22?a=commitdiff_plain;h=b33fb102d1af5e396220226d3a01890ca428e0a5;p=lhc%2Fweb%2Fwiklou.git

changes: Usage of 'noudp' & 'pleasedontudp' no longer exist

Since no usage exist and this was deprecated in 1.31, should it
be removed?

Now I think with the use of Phan and having $send type hinted to
a bool, if a string is used, phan will catch that? :)

Usage
=====

https://codesearch.wmflabs.org/search/?q=(%27noudp%27%7C%27pleasedontudp%27)&i=nope&files=&repos=

Change-Id: Id0482e69e2e2b1cdf0a9ece230e04323bf51324f
---

diff --git a/includes/changes/RecentChange.php b/includes/changes/RecentChange.php
index eed159d8d1..95c9fa6c63 100644
--- a/includes/changes/RecentChange.php
+++ b/includes/changes/RecentChange.php
@@ -369,13 +369,6 @@ class RecentChange implements Taggable {
 	public function save( $send = self::SEND_FEED ) {
 		global $wgPutIPinRC, $wgUseEnotif, $wgShowUpdatedMarker;
 
-		if ( is_string( $send ) ) {
-			// Callers used to pass undocumented strings like 'noudp'
-			// or 'pleasedontudp' instead of self::SEND_NONE (true).
-			// @deprecated since 1.31 Use SEND_NONE instead.
-			$send = self::SEND_NONE;
-		}
-
 		$dbw = wfGetDB( DB_MASTER );
 		if ( !is_array( $this->mExtra ) ) {
 			$this->mExtra = [];
diff --git a/maintenance/dictionary/mediawiki.dic b/maintenance/dictionary/mediawiki.dic
index aa9cb2e4ff..71a15bc85a 100644
--- a/maintenance/dictionary/mediawiki.dic
+++ b/maintenance/dictionary/mediawiki.dic
@@ -2843,7 +2843,6 @@ notvisiblerev
 notwatched
 notwikitext
 notype
-noudp
 noupdates
 nouploadmodule
 nouser